gh-41431: Add datetime.time.strptime() and datetime.date.strptime()#120752
gh-41431: Add datetime.time.strptime() and datetime.date.strptime()#120752pganssle merged 19 commits intopython:mainfrom
datetime.time.strptime() and datetime.date.strptime()#120752Conversation
nineteendo
changed the title
datetime.time.strptime and datetime.date.strptimedatetime.time.strptime() and datetime.date.strptime()
This comment was marked as resolved.
This comment was marked as resolved.
Doc/library/datetime.rst
Outdated
| time tuple. See also :ref:`strftime-strptime-behavior` and | ||
| :meth:`date.fromisoformat`. | ||
|
|
||
| .. note |
There was a problem hiding this comment.
Is it fine to have this note twice in the documentation?
There was a problem hiding this comment.
I think documentation experts will know better than me, but I think there's a way to define a substitution for this, like this:
|format-note|
.. |format-note| replace::
If *format* specifies a day of month without a year a :exc:`DeprecationWarning` is emitted. This is to avoid a quadrenial leap year bug in code seeking to parse only a month and day, as the default year used when unspecified in the format is not a leap year. Such *format* values may raise an error in Python 3.15. The workaround is to always include a year in your *format*. If parsing *date_string* values that do not have a year, explicitly add a year that is a leap year before parsing:
.. doctest::
>> from datetime import date
>> date_string = "02/29"
>> when = date.strptime(f"{date_string};1984", "%m/%d;%Y") # Avoids leap year bug.
>> when.strftime("%B %d") # doctest: +SKIP
'February 29'
.. versionadded:: 3.14
Then you put |format-note| in the other place as well.
Two other options:
- move this to a small fragment file (seems like overkill), and use an
..includedirective with it. - put the note in one place, then link to it in the other place (e.g. "See the note on :func:
datetime.strptime").
I don't think there's a simple way to do it with a parameter, though.
There was a problem hiding this comment.
I was just wondering if it was a problem it was mentioned twice. Do I link to datetime.strptime or is this fine?
I skip my turn :-) |
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
So I had a pending review that I forgot to send. Here are some comments!
Misc/NEWS.d/next/Library/2024-06-19-19-53-42.gh-issue-41431.gnkUc5.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
This looks great so far! I have some suggestions here mostly about the tests.
I'm also working on some hypothesis based tests for this, because there are a couple of properties that we can easily and usefully test here, specifically:
dt == dt.strptime(dt.strftime(format), format) == dtmy_datetime.strftime(format_with_just_dates).date() == my_datetime.date().strftime(format_with_just_dates)my_datetime.strftime(format_with_just_times).time() == my_datetime.time().strftime(format_with_just_times)
I think the key will just be getting a good hypothesis strategy that generates the format strings.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
Awesome, looks good to me! Glad to finally have this done!
|
Thanks @nineteendo! Really great work on this one. Thanks for your patience waiting for reviews and your quick response when the reviews came! |
* main: (69 commits) Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566) pythongh-124412: Add helpers for converting annotations to source format (python#124551) pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561) For-else deserves its own section in the tutorial (python#123946) Add 3.13 as a version option to the crash issue template (python#124560) pythongh-123242: Note that type.__annotations__ may not exist (python#124557) pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479) pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227) pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752) pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856) pythongh-124370: Add "howto" for free-threaded Python (python#124371) pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278) pythongh-119400: make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400 (pythonGH-119401) pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337) pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449) pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490) pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542) pythongh-124513: Check args in framelocalsproxy_new() (python#124515) pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480) Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489) ...
|
Can you close the issue? |
4 participants
📚 Documentation preview 📚:
library/datetime.html